feat(nuxt): Instrument storage API #17858
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
logaretm
force-pushed
the
awad/js-1016-nuxtnitro-instrument-kv-storage-instrumenting-unstorage
branch
from
07cb542 to
24a5470
Compare
logaretm
force-pushed
the
awad/js-1016-nuxtnitro-instrument-kv-storage-instrumenting-unstorage
branch
from
a6dc41f to
fe203a5
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| }, | ||
| }); | ||
|
|
||
| addServerPlugin(moduleDirResolver.resolve('./runtime/plugins/storage.server')); |
There was a problem hiding this comment.
Bug: Incorrect Plugin Path in Storage Configuration
The addServerPlugin call in storageConfig.ts uses an incorrect relative path to the storage server plugin. Since storageConfig.ts is located in the vite directory, ./runtime/plugins/storage.server resolves to the wrong location, preventing the plugin from being found.
There was a problem hiding this comment.
Not a problem, the path isn't relative to current file, but to the module itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR adds automatic instrumentation for Nuxt's storage layer (powered by unstorage), enabling performance monitoring for cache and key-value storage operations in Nuxt/Nitro applications.
Storage operations will now automatically create performance spans with detailed attributes for observability in Sentry.
What's New
nuxt.config.tsvianitro.storagegetItem,setItem,hasItem,removeItemgetItemRaw,setItemRawgetItems,setItemsgetKeys,clearget,set,has,del,removeImplementation Details
Span Attributes:
sentry.op:cache.{operation}(e.g.,cache.get_item,cache.set_item)sentry.origin:auto.cache.nuxtcache.key: Full key including mount prefixcache.hit:truefor successful get/has operationsnuxt.storage.op: Original method namenuxt.storage.mount: Storage mount pointnuxt.storage.driver: Driver name (e.g.,memory,fs,redis)Files Changed:
packages/nuxt/src/runtime/plugins/storage.server.ts- Runtime instrumentation pluginpackages/nuxt/src/vite/storageConfig.ts- Build-time configurationpackages/nuxt/src/module.ts- Module integration